Skip to content

Conversation

@zeha
Copy link
Collaborator

@zeha zeha commented Jan 6, 2026

Short description

When building these dynamically, they need more bits linked. Specifically bindbackend needs the bindparser, and all gsql*backends need gsqlbackend. For gsqlite3backend the situation is more complicated, as the main programs also need ssqlite3.

I've tested the patch against 5.2.0 in a Debian build.

My testing was only the Debian build-time smoke tests for bindbackend, lmdbbackend, gsqlite3backend. Haven't tried the other gsql*backends.

Addresses parts of #13987.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

When building these dynamically, they need more bits linked.
Specifically bindbackend needs the bindparser, and all gsql*backends
need gsqlbackend. For gsqlite3backend the situation is more complicated,
as the main programs also need ssqlite3.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20764046660

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9232 unchanged lines in 120 files lost coverage.
  • Overall coverage decreased (-5.4%) to 67.976%

Files with Coverage Reduction New Missed Lines %
pdns/base64.cc 1 80.6%
pdns/lua-base4.hh 1 0.0%
pdns/recursordist/rec-rust-lib/rust/src/bridge.hh 1 0.0%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/resolver.hh 1 0.0%
pdns/dnstap.cc 2 70.71%
pdns/json.hh 2 0.0%
pdns/recursordist/secpoll-recursor.cc 2 51.69%
pdns/tsigverifier.hh 2 0.0%
pdns/dnsname.hh 3 89.74%
Totals Coverage Status
Change from base Build 20756179712: -5.4%
Covered Lines: 95261
Relevant Lines: 129504

💛 - Coveralls

@rgacogne rgacogne self-requested a review January 16, 2026 14:49
rgacogne
rgacogne previously approved these changes Jan 16, 2026
@rgacogne rgacogne dismissed their stale review January 16, 2026 15:40

Clearly not working in CI even though it's working on my test env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants