Fix: harden SVCB record parsing #16710
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
It was reported that the DNS parser was not strict enough regarding SVC Param ordering and uniqueness.
This could lead us to cache inconsistent data when an MitM or bad authoritative would send double or our of order SVCB Params.
This PR fixes this issue. It also adds a bunch of unit tests and another length validation for ALPN SVC Params.
Checklist
I have: