-
Notifications
You must be signed in to change notification settings - Fork 976
feat(dnsdist): Add global ServerID #16726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+528
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21038114534Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
36d9214 to
521e552
Compare
rgacogne
requested changes
Jan 15, 2026
Member
rgacogne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I have a couple nits but I love it!
521e552 to
4550147
Compare
rgacogne
previously approved these changes
Jan 15, 2026
The label's value is based on the server_id, which is the hostname by default.
4550147 to
12eeb01
Compare
rgacogne
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the option to set a stable "ServerID" for the running dnsdist instance by either using
general.server_idin YAML or the (runtime)setServerIDfunction. By default (and unset), the server's hostname is used.Having this means that no matter how metrics, logs, or traces are sent to different collectors, they can always be attributed to a single dnsdist instance and hence, be correlated.
This ID can (for now) be used by Prometheus, Carbon, and remote logging. Once the structured logging PR (#16691) is merged, the ability to use this identifier in a log-field should be added.
This PR is an attempt to implement #16261.
Checklist
I have: