Minor fixes to PSScript resource#1558
Open
SteveL-MSFT wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small reliability/cleanup adjustments to the PSScript resource wrapper, primarily aimed at ensuring trace output isn’t lost when script execution fails.
Changes:
- Flushes the trace queue before exiting when the invoked script enters a
Failedinvocation state. - Removes an outdated inline comment about non-terminating errors.
Comment on lines
156
to
158
| Write-DscTrace -Now -Level Error -Message $message | ||
| Write-TraceQueue | ||
| exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Minor issues found by AI
Write-TraceQueuebefore exit in failed case so accumulated traces get written