Add defaults kwarg to Form.from_model for runtime prefill#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field(default=...)bakes values into the model class — every render sees the same defaults. That's wrong for the common MCP case where an LLM has collected most of a form's values already and wants the user to edit a pre-filled form rather than a blank one (see PrefectHQ/fastmcp#3930).Form.from_model()now takes adefaultsdict that overlays onto the model's class-level defaults at render time.Partial dicts are fine — missing keys fall back to the model's defaults. Unknown keys raise
ValueErrorto catch typos. Date/time values accept either Pythondate/datetime/timeinstances or ISO strings, so FastMCP can forward raw JSON straight through. The date/time branches also now rendervalue=at all (previously dropped it on the floor — even the class-level default never surfaced).Also fixes a latent bug in
tools/render_previews.py: the module'sfrom __future__ import annotationswas leaking throughexec()and turning every preview's field annotation into aForwardRefstring, which silently broke Pydantic introspection — e.g.Literal[...]fields rendered as text inputs instead of selects. Compiling withdont_inherit=Trueisolates the preview.