feat(worker): add named template for workpool name and base job template#617
Open
cnfrancis wants to merge 1 commit intoPrefectHQ:mainfrom
Open
feat(worker): add named template for workpool name and base job template#617cnfrancis wants to merge 1 commit intoPrefectHQ:mainfrom
cnfrancis wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
525fdbc to
0441a44
Compare
0441a44 to
80cb519
Compare
80cb519 to
d098ce6
Compare
Author
|
hello @mitchnielsen @desertaxle, hope you're all well! |
Member
|
Thanks for the contribution @cnfrancis! Taking a look now. We don't have a set release schedule. We usually create a release after merging a PR. |
Comment on lines
+243
to
+247
| "workPoolName": { | ||
| "type": "string", | ||
| "title": "Work Pool Name", | ||
| "description": "Named template version of workPool allowing to build name dynamically in wrapper charts" | ||
| }, |
Member
There was a problem hiding this comment.
There's a named template matching this, but not a user-configurable Helm value for it, right? We should be able to remove this block.
mitchnielsen
requested changes
Apr 14, 2026
Member
mitchnielsen
left a comment
There was a problem hiding this comment.
This is looking good overall, just a suggestion on the added Helm value. Could you also please add some unit tests to make sure this is working as expected? You can see examples in charts/prefect-*/tests/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Have this use case to be able to deploy the same workpools to different data centers in different regions.
Using argocd at runtime we inject such information which we consume in an internal wrapper chart.
The change introduced in this PR will allow us to redefine the named template in our wrapper chart so that following in argocd will work:
From this above in our wrapper chart - will be able to build the workpool name dynamically as well allow dictionary merging of baseJobTemplate
Otherwise we have to duplicate per region e.g
The changes suggested aim to be backward compatible hence why it is wrapped in a named template with the same value reference as before.
Requirements
Closes <issue>, if availabletemplates/NOTES.txtDraftstatus is used until ready for review