Skip to content

Add server default result storage config surface#21075

Closed
zzstoatzz wants to merge 3 commits intomainfrom
codex/storage-default-config-surface
Closed

Add server default result storage config surface#21075
zzstoatzz wants to merge 3 commits intomainfrom
codex/storage-default-config-surface

Conversation

@zzstoatzz
Copy link
Copy Markdown
Collaborator

@zzstoatzz zzstoatzz commented Mar 10, 2026

this PR adds the OSS config surface for a server-level default result storage setting.

What changed
  • adds a ServerDefaultResultStorage schema for representing the configured block document id
  • adds /admin/storage read, update, and clear endpoints
  • adds client methods for reading, updating, and clearing the server default result storage setting
  • validates that the configured block exists and supports write-path
  • keeps storage-default-specific validation and persistence in a dedicated server.models.storage_defaults module instead of leaving that logic inline in the route
  • syncs the generated ui-v2 OpenAPI client for the new admin surface
Why this is a separate slice

This PR only adds the configuration surface for storing a server default result storage block. It does not change runtime result-storage resolution yet.

That separation keeps the persisted setting and API contract reviewable on their own before the follow-up runtime behavior work lands.

Verification
  • uv run pytest tests/server/api/test_admin.py tests/server/models/test_storage_defaults.py tests/client/test_prefect_client.py -k 'server_default_result_storage'
  • uv run pytest tests/server/models/test_configuration.py tests/server/models/test_storage_defaults.py
  • uv run ruff check src/prefect/server/api/admin.py src/prefect/server/models/__init__.py src/prefect/server/models/configuration.py src/prefect/server/models/storage_defaults.py tests/server/api/test_admin.py tests/server/models/test_configuration.py tests/server/models/test_storage_defaults.py tests/client/test_prefect_client.py
  • repo hooks passed during commit and push, including mypy and Sync UI v2 OpenAPI

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 10, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing codex/storage-default-config-surface (78a9f1a) with main (b89b43d)

Open in CodSpeed

@zzstoatzz zzstoatzz force-pushed the codex/storage-default-config-surface branch from e3f5110 to b33f43a Compare March 10, 2026 20:30
@github-actions
Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it.

@github-actions github-actions bot closed this Apr 7, 2026
Copy link
Copy Markdown
Collaborator Author

Superseded by #21532 after rebasing codex/storage-default-config-surface onto current main and refreshing the PR description. Keeping this closed PR as historical reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant