Add PgBouncer support via NullPool configuration#21525
Draft
Add PgBouncer support via NullPool configuration#21525
Conversation
github-actions
bot
added
enhancement
Setting `PREFECT_SERVER_DATABASE_SQLALCHEMY_POOL_SIZE=null` disables SQLAlchemy's internal connection pool (using NullPool), allowing external connection poolers like PgBouncer to manage connections instead. closes #18616 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
asyncpg requires scram-sha-256 auth with PostgreSQL 14+, which is not PgBouncer's default. Discovered during E2E testing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restores the original model_dump() approach and removes the deferred import. Cleaner diff and less likely to drift if new settings are added. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zzstoatzz
force-pushed
the
support-pgbouncer-nullpool
branch
from
ef6ac6d to
e0909a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18616
Summary
PREFECT_SERVER_DATABASE_SQLALCHEMY_POOL_SIZE=nullto use SQLAlchemy'sNullPool, disabling internal connection pooling for external poolers like PgBouncerpool_sizeisNone, pool-related kwargs (pool_pre_ping,pool_use_lifo,pool_timeout,max_overflow) are excluded sinceNullPooldoesn't support themrevives #18643
The original PR was closed by the stale bot. This is a fresh implementation rebased on current main with the same approach — community members have been asking for this (see comments on the original PR).
Test plan
TestNullPoolConfigurationverifiesNullPoolis used whenpool_size=Noneand regular pool whenpool_sizeis an integerPREFECT_SERVER_DATABASE_SQLALCHEMY_POOL_SIZE=nullenv var parses correctly🤖 Generated with Claude Code