New error handling for unsupported image types

[buggyzap]

Questions	Answers
Description?	I have added a new error for users who upload a file that is not supported in extensions and/or mimetype.
Type?	improvement
BC breaks?	no
Deprecations?	no
How to test?	Try to upload a new file that is not supported.

If we try to upload a new file that is not a valid image, no errors are shown. Backoffice returns success message and image remain the same. With this little "else" check we can track if the uploaded file was included in supported extensions and/or mimetypes.

[florine2623]

Hello @buggyzap ,

Thanks for the PR !

The error message is displayed twice. Could you make it so that it appears just once ?

It would also be better to have a message like so : Image format not recognized, allowed formats are: gif, jpg, jpeg, jpe, png, webp.

Thanks!

[kpodemski]

ping @buggyzap

I think you didn't need to use $this->displayError :)

[ps-jarvis]

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

• Admin.Notifications.Error
  • Image format not recognized, allowed formats are: jpg, gif, jpeg, png.

(Note: this is an automated message, but answering it will reach a real human)

[buggyzap]

ping @buggyzap

I think you didn't need to use $this->displayError :)

Ok ty

[florine2623]

Hello @buggyzap ,

With your PR, I can't add any slider anymore. The error message is always displayed, whether I upload a supporter or unsupported image type.

When I upload a jpg or png, or any supported format, the error is displayed once.
If I upload an unsupported image format, the error is displayed twice.

Screen.Recording.2024-07-04.at.12.00.58.mov

Could you check please ?
Thanks

[kpodemski]

missclick @boherm ?

[boherm]

missclick @boherm ?

I haven't see the Florine's comment.. 😅

[florine2623]

friendly reminder @buggyzap :D