You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enable uploading videos for the image slider. File type checks were updated as well as new poster column is added to the database to store the video poster filename
Type?
new feature
BC breaks?
no
Deprecations?
no
Fixed ticket?
Sponsor company
How to test?
Upload .mp4 files. Disable theme overwrite of slider.tpl file so the default module one will be used
@Hlavtox
I created a new PR, since the old one was targeting the wrong branch on my fork. You left the following comment there:
I think it's too complicated. If something, I would enable people to upload properly formatted MP4 or WEBM. Everyone have different needs for quality and file size.
Also, please remove the change of author.
✅ Authors fixed
Could you please elaborate more about why it is too complicated please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postercolumn is added to the database to store the video poster filename.mp4files. Disable theme overwrite ofslider.tplfile so the default module one will be used