Skip to content

fix(AdminController): ob_end_clean without content creates error#121

Open
Kaikina wants to merge 5 commits intoPrestaShop:devfrom
Kaikina:fix_ob_clean
Open

fix(AdminController): ob_end_clean without content creates error#121
Kaikina wants to merge 5 commits intoPrestaShop:devfrom
Kaikina:fix_ob_clean

Conversation

@Kaikina
Copy link

@Kaikina Kaikina commented Feb 2, 2026

Questions Answers
Description? When debug mode is active, reordering slides provokes a symfony exception, as we call ob_end_clean when there is no buffer content to clean. Notice: ob_end_clean(): Failed to delete buffer. No buffer to delete
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? NA
Sponsor company Evolutive
How to test? Activate debug mode. Go to the module configuration and change slides order. Check in the network tab of the browser that calls made to update positions are not returning errors.

Touxten
Touxten previously approved these changes Feb 11, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Feb 11, 2026
jf-viguier
jf-viguier previously approved these changes Feb 11, 2026
@Touxten Touxten dismissed stale reviews from jf-viguier and themself via ebc4bf8 February 20, 2026 08:26
@Touxten Touxten closed this Feb 25, 2026
@github-project-automation github-project-automation bot moved this from Ready for review to Closed in PR Dashboard Feb 25, 2026
@Touxten Touxten reopened this Feb 25, 2026
@github-project-automation github-project-automation bot moved this from Closed to Reopened in PR Dashboard Feb 25, 2026
@Touxten Touxten requested a review from jf-viguier February 26, 2026 08:17
Copy link

@paulnoelcholot paulnoelcholot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Kaikina,

Before to create a PR, you need to create an issue.

I try to reproduce the problem without your PR and as you can see, I can't.

Please to create issue and if we can reproduce it, we will test your PR.

Thank you for your understanding.

PR-2026-02-26_11.21.46.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Reopened

Development

Successfully merging this pull request may close these issues.

6 participants