SQL query improvement to check active products#41
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Perhaps it's better to keep the same method name, and the same default behavior which is a select without condition. And only fair to co-author @joshjackson 😀 |
|
The https://github.com/PrestaShop/ps_viewedproduct/tree/dev/tests/phpstan
The method is private no problem but i aggree you. If someone has overridden the private method, their override will no longer work.
The shop condition optilmize the request |
The SQL query must use "product_shop" table, not "product" Fix Test Fiix PHPstan before PS 8.0.0 Keep the old name of the method
31d5ec1 to
536c267
Compare
|
@PrestaShop/qa-functional can we have your eyes here ? it's an easy one. |
|
Up voted |
SiraDIOP
left a comment
There was a problem hiding this comment.
Hello @Prestaplugins,
Thanks for your PR,
I tested it and it's good for me
Enregistrement.de.l.ecran.2026-02-04.a.17.28.51.mov
Thank you
How to test :
Activate the "Viewed product" module
Turn debug profiling ON
Enter a product page
Then go to another one
Check the query in the debug profiling, it must contains "AND p.id_product IN ( .... )" with a small number of rows returned.