Display a placeholder that indicates "no photos available" when appli…#261
Draft
tarabassir wants to merge 1 commit intomasterfrom
Draft
Display a placeholder that indicates "no photos available" when appli…#261tarabassir wants to merge 1 commit intomasterfrom
tarabassir wants to merge 1 commit intomasterfrom
Conversation
emillipede
reviewed
Dec 3, 2019
| this.heritageTreeNumber = document.getElementById('sidebar-heritage-number'); | ||
| this.heritageTreeNumber = document.getElementById('sidebar-heritage-number'); | ||
| this.heritageTreeNumber = document.getElementById('sidebar-heritage-number'); | ||
| this.heritageTreeNumber = document.getElementById('sidebar-heritage-number'); |
Collaborator
There was a problem hiding this comment.
what's changed here? I'm not quite sure why this.heritageTreeNumber = document.getElementById('sidebar-heritage-number'); appears twice in a row, but it was written that way before, too
Author
There was a problem hiding this comment.
I don't recall changing this part. Maybe I changed it by accident, it's not a part of my solution
Collaborator
|
thank you @tarabassir ! until we design a placeholder that displays "no photos available" I'd like to use an icon as a placeholder. I'm sorry I didn't clarify it in the issue. I just added a noun project icon to the repo icons folder. could you please substitute this image for the current "no photos available" text? thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
#254
Screenshots
What I did
Added a span inside the div with id="sidebar-tree", and made it only visible when there is no picture available.