Add pip channel hardware configuration query (VW command)#991
Merged
rickwierenga merged 5 commits intoPyLabRobot:mainfrom Apr 17, 2026
Merged
Add pip channel hardware configuration query (VW command)#991rickwierenga merged 5 commits intoPyLabRobot:mainfrom
rickwierenga merged 5 commits intoPyLabRobot:mainfrom
Conversation
Adds PipChannelInformation dataclass and _pip_channel_request_configuration() to query per-channel installed hardware via the firmware VW command. Returns channel type, head type, stop disc type (CO-RE I/II), and pressure sensor ADC type for each pipetting channel. Cached in _pip_channel_information during setup, matching the _head96_information pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use if/else pattern matching head96 instead of dict.get() with str fallback. Add assert for _num_channels to satisfy Optional[int] check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| pressure_adc="Analog_Devices_AD5263" if hw_tokens[3] == "1" else "Renesas_X9268", | ||
| ) | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
why wouldn't _pip_channel_request_configuration return PipChannelInformation directly?
Co-authored-by: Rick Wierenga <rick_wierenga@icloud.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
This PR creates an error for my April 2015 firmware Starlet. I created an issue here: #1004 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PipChannelInformationdataclass and_pip_channel_request_configuration()to query per-channel installed hardware via the firmware VW command_pip_channel_informationduring setup, matching the_head96_informationpatternTest plan
vw0 0 1 0(ML_STAR, ML_STAR head, CO-RE II, Renesas X9268)🤖 Generated with Claude Code