feat: Add the shared client theme object on message sent and in message object#3209
Open
UnBonWhisky wants to merge 10 commits intoPycord-Development:masterfrom
Open
feat: Add the shared client theme object on message sent and in message object#3209UnBonWhisky wants to merge 10 commits intoPycord-Development:masterfrom
UnBonWhisky wants to merge 10 commits intoPycord-Development:masterfrom
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3209/head:pr-3209
git checkout pr-3209This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3209/head |
UnBonWhisky
changed the title
Contributor
Author
|
Note : shared client theme should not work with components v2 (source: Discord docs) but it works. 
|
Paillat-dev
requested changes
Apr 26, 2026
|
|
||
|
|
||
| class SharedClientThemeBaseType(Enum): | ||
| """The base theme mode of a :class:`SharedClientTheme`. |
Member
There was a problem hiding this comment.
Having the docs here is not necessary I think since you have them in enums.rst anyways
| if not 0 <= gradient_angle <= 360: | ||
| raise ValueError("gradient_angle must be between 0 and 360") | ||
|
|
||
| if not isinstance(base_mix, int) or isinstance(base_mix, bool): |
| if len(normalized) > 5: | ||
| raise ValueError("colors must contain at most 5 colors") | ||
|
|
||
| if not isinstance(gradient_angle, int) or isinstance(gradient_angle, bool): |
| DEALINGS IN THE SOFTWARE. | ||
| """ | ||
|
|
||
| from __future__ import annotations |
Member
There was a problem hiding this comment.
We don't need it here I think
| Shared Client Theme | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| .. attributetable:: SharedClientTheme |
Member
There was a problem hiding this comment.
Is it actually a data class ?
plun1331
requested changes
Apr 26, 2026
Member
plun1331
left a comment
plun1331
left a comment
There was a problem hiding this comment.
Since shared client theme is constructible, I feel like we should add methods like set_colors and whatnot to make that easier
| role, | ||
| scheduled_events, | ||
| ) | ||
| from .types import shared_client_theme as shared_client_theme_type |
Comment on lines
+92
to
+93
| if len(normalized) > 5: | ||
| raise ValueError("colors must contain at most 5 colors") |
Member
There was a problem hiding this comment.
Check both of these first before coercion
| ): | ||
| raise TypeError("base_theme must be a SharedClientThemeBaseType or None") | ||
|
|
||
| self.colors: list[str] = normalized |
Member
There was a problem hiding this comment.
A way to easily get these as int or Color would be nice
|
|
||
| def __init__( | ||
| self, | ||
| colors: Iterable[ColourLike], |
| ): | ||
| raise TypeError("base_theme must be a SharedClientThemeBaseType or None") | ||
|
|
||
| self.colors: list[str] = normalized |
Dorukyum
reviewed
May 9, 2026
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Feature freeze is active, as described by our Release Schedule.
Summary
It adds the object of shared client theme described here by Discord.
Yes AI has been used (partially)
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.