Support stage2_ef_solver_name from generic_cylinders#651
Closed
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
Closed
Support stage2_ef_solver_name from generic_cylinders#651DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
Conversation
Register the stage2 EF solver option in xhatshuffle_args() so it is available as --stage2-ef-solver-name from the generic_cylinders CLI. Rename the option from stage2EFsolvern to stage2_ef_solver_name to follow project naming conventions. Relax the hard assertion requiring this option for multistage xhatshuffle to a warning, since the regular multi-stage xhat path also works. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
- Coverage 70.16% 70.16% -0.01%
==========================================
Files 153 153
Lines 18905 18908 +3
==========================================
+ Hits 13265 13266 +1
- Misses 5640 5642 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DLWoodruff
added a commit
to DLWoodruff/mpi-sppy-1
that referenced
this pull request
Apr 15, 2026
6 tasks
Collaborator
Author
DLWoodruff
added a commit
to DLWoodruff/mpi-sppy-1
that referenced
this pull request
Apr 15, 2026
PR Pyomo#651 relaxed a hard assert into a warnings.warn call when multistage xhatshuffle is used without --stage2-ef-solver-name. Without a test, silent drift (warning removed, branch not taken) would go unnoticed. Covers both cases: warning fires when missing, does not fire when set. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stage2_ef_solver_nameinxhatshuffle_args()so--stage2-ef-solver-nameis available from thegeneric_cylinders.pyCLIstage2EFsolvern→stage2_ef_solver_nameacross the codebase to follow project naming conventions (snake_case config, dashed CLI flags)generic_cylinders.rst("Multistage Options" section) and updatespokes.rststage2_ef_solver_nameintest_with_cylinders.pyTest plan
ruff check .passes on all modified filespython -m pytest mpisppy/tests/test_ef_ph.pypasses (26 passed, 2 skipped)mpiexec -np 2 python -m mpi4py mpisppy/tests/test_with_cylinders.pypasses (5 passed including new hydro stage2ef test)examples/generic_tester.pysmoke test (exercises hydro via generic_cylinders with--stage2-ef-solver-name)🤖 Generated with Claude Code