Skip to content

Add generic_cylinders.py path for aircond; archive aircond_ef.py#662

Open
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
DLWoodruff:aircond_update
Open

Add generic_cylinders.py path for aircond; archive aircond_ef.py#662
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
DLWoodruff:aircond_update

Conversation

@DLWoodruff
Copy link
Copy Markdown
Collaborator

Summary

Conservative migration — aircond is heavily rst-documented (examples.rst, properbundles.rst, amalgamator.rst, seqsamp.rst) and also referenced from the external DLWoodruff/aircond companion repo, so existing driver filenames are preserved.

  • Archive examples/aircond/aircond_ef.py (no callers anywhere) under examples/aircond/archive/.
  • examples/run_all.py: add a parallel generic_cylinders.py --module-name ../../mpisppy/tests/examples/aircond invocation next to the existing aircond_cylinders.py entry. generic_cylinders asserts --stage2EFsolvern for multistage --xhatshuffle and aircond.py doesn't register that option, so the parallel entry uses --xhatxbar instead; the xhatshuffle path stays covered by the custom driver above.
  • doc/src/examples.rst: expand the aircond section to note that runs can go through the generic driver too (pointing --module-name at mpisppy/tests/examples/aircond); aircond_cylinders.py stays the rst's starting-point / bundles worked example.

Retained in place: aircond_cylinders.py, aircond_ama.py, aircond_seqsampling.py, bundle_pickler.py (all rst-referenced), and every bash/slurm script.

Test plan

  • mpiexec -np 3 python -m mpi4py ../../mpisppy/generic_cylinders.py --module-name ../../mpisppy/tests/examples/aircond --branching-factors '4 3 2' --max-iterations=5 --default-rho=1 --lagrangian --xhatxbar --solver-name=gurobi_persistent — runs, lagrangian + xhatxbar converge to ~3.7% cylinder gap after 5 iters
  • ruff check examples/run_all.py
  • CI run_all job on this PR

🤖 Generated with Claude Code

aircond.py (model module at mpisppy/tests/examples/aircond.py) already
exposes scenario_creator, scenario_names_creator, kw_creator,
inparser_adder, scenario_denouement, and sample_tree_scen_creator, so
the generic driver can run it. This is a conservative migration —
aircond is heavily rst-documented (examples.rst, properbundles.rst,
amalgamator.rst, seqsamp.rst) and also referenced from the external
https://github.com/DLWoodruff/aircond companion repo — so existing
driver filenames stay put.

- Archive examples/aircond/aircond_ef.py (no callers anywhere)
  under examples/aircond/archive/.
- run_all.py: add a generic_cylinders entry paralleling the existing
  aircond_cylinders.py invocation. generic_cylinders enforces
  --stage2EFsolvern for multistage xhatshuffle and aircond.py doesn't
  register that option, so the parallel entry uses --xhatxbar instead;
  the xhatshuffle path is still covered by the custom driver above.
- doc/src/examples.rst: expand the aircond blurb to say runs can go
  through generic_cylinders.py too; keep aircond_cylinders.py as the
  starting-point / bundles worked example.

Retained: aircond_cylinders.py, aircond_ama.py, aircond_seqsampling.py,
bundle_pickler.py (all rst-referenced), and all bash/slurm scripts.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.72%. Comparing base (b726347) to head (d32cf20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   70.71%   70.72%   +0.01%     
==========================================
  Files         153      153              
  Lines       19005    19005              
==========================================
+ Hits        13439    13442       +3     
+ Misses       5566     5563       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants