Migrate sslp harness to include a generic_cylinders.py entry#664
Open
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
Open
Migrate sslp harness to include a generic_cylinders.py entry#664DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
DLWoodruff wants to merge 1 commit intoPyomo:mainfrom
Conversation
sslp.py already exposes scenario_creator, scenario_names_creator, kw_creator, inparser_adder, scenario_denouement, and sample_tree_scen_creator, so the generic driver can run it. All of the flags used by sslp_cylinders.py (--instance-name, --sslp-data-path, --surrogate-nonant, --integer-relax-then-enforce, --reduced-costs-rho, --use-primal-dual-rho-updater, etc.) are already registered through cfg in generic_cylinders too. - Archive examples/sslp/sslp_ef.py (no callers anywhere) under examples/sslp/archive/. - run_all.py: add a generic_cylinders invocation paralleling the retained sslp_cylinders.py entry, using the same flags. - doc/src/examples.rst: reword the sslp section to say runs go through the generic driver by default and that sslp_cylinders.py is retained as the worked custom-driver example. Retained: sslp.py (model, also the scenario_creator.rst surrogate-nonant example), sslp_cylinders.py (rst), and sslp_demo.bash. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 70.71% 70.72% +0.01%
==========================================
Files 153 153
Lines 19005 19005
==========================================
+ Hits 13439 13441 +2
+ Misses 5566 5564 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bknueven
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sslp.py already exposes
scenario_creator,scenario_names_creator,kw_creator,inparser_adder,scenario_denouement, andsample_tree_scen_creator, so the generic driver can run it. All the flags used bysslp_cylinders.py(--instance-name,--sslp-data-path,--surrogate-nonant,--integer-relax-then-enforce,--reduced-costs-rho,--use-primal-dual-rho-updater, etc.) are already registered through cfg in generic_cylinders too, so the parallel entry can use the same options.examples/sslp/sslp_ef.py(no callers anywhere) underexamples/sslp/archive/.examples/run_all.py: add ageneric_cylinders.py --module-name sslpentry paralleling the retainedsslp_cylinders.pyone.doc/src/examples.rst: reword the sslp section to say runs go through the generic driver by default and thatsslp_cylinders.pyis retained as the worked custom-driver example.Retained:
sslp.py(model, also thescenario_creator.rstsurrogate-nonant example),sslp_cylinders.py(rst-referenced), andsslp_demo.bash.Test plan
mpiexec -np 4 python -m mpi4py ../../mpisppy/generic_cylinders.py --module-name sslp --instance-name=sslp_15_45_10 --sslp-data-path=./data --integer-relax-then-enforce --integer-relax-then-enforce-ratio=0.8 --lagrangian --reduced-costs-rho --max-iterations=20 --default-rho=1e-6 --reduced-costs --rc-fixer --xhatshuffle --linearize-proximal-terms --rel-gap=0.0 --surrogate-nonant --use-primal-dual-rho-updater --primal-dual-rho-update-threshold=10 --solver-name=gurobi_persistent— runs, converges to ~4.7% cylinder gap after 20 itersruff check examples/run_all.py🤖 Generated with Claude Code