Add 2 new states for ZeoState in zeo_code_mappings #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOisi-x
commented
Dec 18, 2025
Contributor
Author
NOisi-x
left a comment
NOisi-x
left a comment
There was a problem hiding this comment.
The status of these two values was inferred based on the operation of the washing machine.
Device model: roborock.wm.a114
allenporter
reviewed
Dec 22, 2025
| done = 10 | ||
|
|
||
| aftercare = 12 | ||
| waitingforaftercare = 13 |
Contributor
There was a problem hiding this comment.
Should the value have underscores between words similar to under_delay_start?
(I assuming this is parsed by number and not string name)
Contributor
Author
There was a problem hiding this comment.
It is indeed parsed by number and the string name is defined, so it can be changed if there are any formatting requirements for the string name.
Contributor
There was a problem hiding this comment.
OK follow the existing pattern please where underscores are used between words
Lash-L
reviewed
Jan 18, 2026
Lash-L
approved these changes
Jan 18, 2026
Collaborator
|
Thank you @NOisi-x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 new states for ZeoState in zeo_code_mappings.
aftercare = 12
waitingforaftercare = 13