feat: add the ability to set q7 mode #748
Open
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to set the cleaning mode (vacuum, mop, or both) for the Roborock Q7 device, addressing the Q7's requirement to explicitly set the cleaning mode before it will function properly.
Changes:
- Added
set_modeAPI method to control Q7 cleaning mode - Changed
waterandmodefields in B01Props fromintto proper enum types for improved type safety - Added comprehensive test coverage for the new mode-setting functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/devices/traits/b01/q7/test_init.py | Added parametrized test for set_mode method covering all three cleaning modes (vacuum, mop, vac_and_mop) |
| roborock/devices/traits/b01/q7/init.py | Implemented set_mode method following the existing pattern for property setters |
| roborock/data/b01_q7/b01_q7_containers.py | Changed water and mode fields from int to enum types (WaterLevelMapping and CleanTypeMapping) for better type safety |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Q7 mode is interesting and a bit different than V1. You must explicitly set what mode you want to be in otherwise it will not work. You can change the mop mode while in vacuum mode, but it wont actually mop unless you change the mode.
Relates: #739