Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Jan 18, 2026

fixes #523

  • Changes finish reason to a modeEnum to better handle duplicates.
  • adds finish reason for 78 and 79
  • This is not use don the HA side but I have been meaning to add a entity for it.

Copilot AI review requested due to automatic review settings January 18, 2026 03:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the RoborockFinishReason enum from RoborockEnum to RoborockModeEnum to better handle duplicate finish reason codes, and adds two new finish reason codes (78 and 79) for pet furniture detection features.

Changes:

  • Converted RoborockFinishReason to use RoborockModeEnum with tuple-based values (name, code)
  • Added CHECK_SAVED_PET_FURNITURES (code 78) and GET_SAVED_PET_FURNITURES (code 79) finish reasons
  • Updated tests to access the finish reason code via the .code attribute

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
roborock/data/v1/v1_code_mappings.py Migrated RoborockFinishReason from RoborockEnum to RoborockModeEnum, added two new finish reason codes (78, 79), and fixed a typo in FINISHED_CLEANING_5
tests/devices/traits/v1/test_clean_summary.py Updated test assertions to check finish_reason.code instead of direct value comparison
tests/data/v1/test_v1_containers.py Updated test assertions to check finish_reason.code instead of direct value comparison

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lash-L Lash-L marked this pull request as draft January 18, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing RoborockFinishReason code: 78 - defaulting to 21

2 participants