fix(server/player): move health init into OnPlayerLoaded to prevent being dead in spawn selection#713
Open
iloomilo wants to merge 4 commits intoQbox-project:mainfrom
Open
fix(server/player): move health init into OnPlayerLoaded to prevent being dead in spawn selection#713iloomilo wants to merge 4 commits intoQbox-project:mainfrom
iloomilo wants to merge 4 commits intoQbox-project:mainfrom
Conversation
…ther spawn resources, provide config option
…to prevent dead spawns
Author
|
I’ve rethought this and committed a better solution. The initialization now stays within qbx_core, so there’s no need to modify the spawn resource. Optionally, initialization can be disabled in the server config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the health initialization from the CreatePlayer() function.
With a dedicated spawn resource, setting health here is unnecessary and may cause players to spawn dead during selection if their saved health metadata is 0.
It should also address this and related issues but I didn't test it directly for qbx_medical, just encountered a similar issue while developing my own medical resource:
Fixes Qbox-project/qbx_medical#115
Checklist