refactor: improve ped loading, error handling, and config management#733
Closed
LenixDev wants to merge 5 commits intoQbox-project:mainfrom
Closed
refactor: improve ped loading, error handling, and config management#733LenixDev wants to merge 5 commits intoQbox-project:mainfrom
LenixDev wants to merge 5 commits intoQbox-project:mainfrom
Conversation
- Move defaultSpawn require statement after early return condition - Keep character module logic clear when using external characters - Adjust whitespace for better readability
- Update randomPed function to accept accurateModelIndex for precise model selection - Modify spawnDefault function to pass accurateModelIndex to randomPed when provided - Change spawnDefault call to use character gender as accurateModelIndex parameter - Ensure player model and appearance setting respects the accurate model choice - Keep existing screen fade and spawn manager logic intact with new parameter support
- Wrap exports.chat:addMessage calls with pcall to catch and log errors - Add error printing using lib.print.error on failure - Ensure player OOC and proximity OOC message sending is safely handled - Improve robustness of chat messaging in client and server scripts
- Update serverName to dynamically use GetConvar('sv_hostname', 'Server')
- Ensure serverName reflects current server hostname configuration
- Keep default spawn position and notify position unchanged
- Removed extensive list of nationalities from data/nationalities.lua - Added a new list featuring fictional locations from a game universe - Simplified return table to focus on place names instead of nationalities - Improved maintainability by narrowing scope of data provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist