fix: add missing Go and JavaScript syntax highlighting in admin CodeMirror#142
Open
NYCU-Chung wants to merge 1 commit into
Open
fix: add missing Go and JavaScript syntax highlighting in admin CodeMirror#142NYCU-Chung wants to merge 1 commit into
NYCU-Chung wants to merge 1 commit into
Conversation
…irror The OJ frontend CodeMirror imports Go and JavaScript modes, but the admin CodeMirror only imports C/C++ and Python. This causes Go and JavaScript code to render without syntax highlighting in the admin panel (e.g. when editing problem templates or viewing submissions). Fixes QingdaoU#77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The admin panel's CodeMirror editor only imports C/C++ (
clike) and Python syntax modes. Go and JavaScript code renders as plain text without any syntax highlighting.The OJ frontend's CodeMirror (
src/pages/oj/components/CodeMirror.vue) already imports bothgoandjavascriptmodes, but the admin version (src/pages/admin/components/CodeMirror.vue) is missing them.Fixes #77
Fix
Add the two missing imports to the admin CodeMirror component: