Skip to content

Conversation

@Varixo
Copy link
Member

@Varixo Varixo commented Jan 2, 2026

Save original object instance on prop, but serialize when we set attribute on element. This way we can compare signals without untracking and tracking them again.

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2026

⚠️ No Changeset found

Latest commit: 2dc3638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8221
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8221
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8221
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8221

commit: 2dc3638

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 2dc3638

Base automatically changed from v2-wrapped-signal-fn-hoisting to build/v2 January 4, 2026 15:44
@Varixo Varixo force-pushed the v2-diff-signal branch 2 times, most recently from c83f34d to 985f8e5 Compare January 4, 2026 21:56
@Varixo Varixo self-assigned this Jan 5, 2026
@Varixo Varixo moved this from Backlog to In progress in Qwik Development Jan 5, 2026
@Varixo Varixo moved this from In progress to Waiting For Review in Qwik Development Jan 5, 2026
@Varixo Varixo marked this pull request as ready for review January 5, 2026 15:36
@Varixo Varixo requested a review from a team as a code owner January 5, 2026 15:36
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 91321d4 into build/v2 Jan 6, 2026
21 checks passed
@wmertens wmertens deleted the v2-diff-signal branch January 6, 2026 08:25
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants