feat(sim): add SimulationControl + VehicleSimulatorControl interfaces#161
Merged
Conversation
Real-time v1 of the simulation control surface, split by axis: - SimulationControl: domain-agnostic lifecycle (start/pause/stop), served per-entity on the simulated entity's own id. Per-RPC empty response messages so each command can grow return fields without a breaking type change. State machine + INVALID_STATE error contract documented inline. - VehicleSimulatorControl: vehicle-specific set_initial_pose(InitialPose), placing a statically-declared entity. No spawn/despawn — identity is static config so downstream connectors can bind to entity_ids up front. Entity creation (dynamic spawn) and faster-than-real-time scenario control are deliberately out of scope; both are additive future interfaces that leave this contract unchanged. Also fix the lone camelCase field in SimulationStatus (timestampSimulation -> simulation_timestamp; wire tag unchanged). Namespace/collision concerns for interface wrappers tracked in #159. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reordered SimulationState values for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-time v1 of the simulation control surface, split by axis:
Entity creation (dynamic spawn) and faster-than-real-time scenario control are deliberately out of scope; both are additive future interfaces that leave this contract unchanged.
Also fix the lone camelCase field in SimulationStatus (timestampSimulation -> simulation_timestamp; wire tag unchanged).
Namespace/collision concerns for interface wrappers tracked in #159.