Modified RecordsFactory to allow passing source data as InputStream, …#34
Open
carenini wants to merge 1 commit intoRMLio:masterfrom
Open
Modified RecordsFactory to allow passing source data as InputStream, …#34carenini wants to merge 1 commit intoRMLio:masterfrom
carenini wants to merge 1 commit intoRMLio:masterfrom
Conversation
…instead of reading them from file or from remote url. RecordsFactory can accept a Map<named_stream,InputStream>, where named_stream has the format "label://sourcename" and match with the source value in the mapping file.
Collaborator
|
Hi @carenini We understand the need to support InputStreams directly, but we advice against encoding that information directly in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…instead of reading them from file or from remote url.
RecordsFactory can accept a Map<named_stream,InputStream>, where named_stream has the format "label://sourcename" and match with the source value in the mapping file.
This way the RML mapper works accepting a mapping file plus a map of named inputs, and can work with in-memory data instead of fetching from pre-defined file/url locations.