[AOMP] Turn off Fortran runtimes when flang is disabled#1572
Open
jtb20 wants to merge 1 commit intoROCm:aomp-devfrom
Open
[AOMP] Turn off Fortran runtimes when flang is disabled#1572jtb20 wants to merge 1 commit intoROCm:aomp-devfrom
jtb20 wants to merge 1 commit intoROCm:aomp-devfrom
Conversation
This patch makes builds without Flang avoid building/linking Fortran runtime libraries, since not doing that currently leads to build failures (i.e. with AOMP_SKIP_FLANG_NEW=1).
jtb20
requested review from
estewart08,
gregrodgers and
ronlieb
as code owners
ronlieb
reviewed
Sep 15, 2025
| if [ "$AOMP_LEGACY_OPENMP" != 0 ]; then | ||
| LLVM_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt" | ||
| else | ||
| LLVM_RUNTIMES="libcxx;libcxxabi;libunwind;openmp;offload;compiler-rt;flang-rt" |
Contributor
There was a problem hiding this comment.
flang project enables flang-rt , so it does not need to be in the LLVM_RUNTIMES, this is recent change that Kruse can confirm.
ronlieb
reviewed
Sep 15, 2025
| if [ "$_hostarch" == "x86_64" ] ; then | ||
| # These components build on x86_64, so add them to components list | ||
| if [ "$AOMP_SKIP_FLANG" == 0 ] ; then | ||
| components="$components llvm-classic flang-classic pgmath flang flang_runtime" |
Contributor
There was a problem hiding this comment.
pgmath flang and flang_runtime are all 3 classic flang specific, it does not make sense to me to separate out flang_runtime. perhaps this is conflated with flang-rt ?
ronlieb
reviewed
Sep 15, 2025
| fi | ||
| fi | ||
|
|
||
| declare -a _omptarget_fortrt_opt |
|
This is a test comment (pre Ron's instructions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes builds without Flang avoid building/linking Fortran runtime libraries, since not doing that currently leads to build failures (i.e. with
AOMP_SKIP_FLANG_NEW=1).