[SROCK] use ninja install instead of rsync from dist/rocm. See list of other updates below#2089
Merged
gregrodgers merged 1 commit intoaomp-devfrom Mar 16, 2026
Merged
Conversation
… cleanups...
- Replace rsync install with direct install by TheRock with -DCMAKE_INSTALL_PREFIX="$SROCK_INSTALL_DIR"
- Removed patch to profiler/CMakeLists.txt
- Moved SROCK_CONFIG settings to srock_common_vars
- Removed -DTHEROCK_ENABLE_HIP
- Removed special cloning of ROCGDB and ROCDGBAPI because they are now included with TheRock build
- Added -DTHEROCK_ENABLE_AMD_DBGAPI=ON -DTHEROCK_ENABLE_ROCGDB=ON to the default "minimal" build.
Also removed build of amddbgapi and rocgdb in prebuild_srock.sh
- Added a note in the log to show the ROCm version found in version.json as well as the SROCK_VERSION_STRING
- Removed script copying of FileCheck because TheRock builds and installs it.
- Improved the README to better compare AOMP to SROCK and documented the compiler development flow with srock.
gregrodgers
requested review from
carlobertolli,
estewart08,
ronlieb and
zGoldthorpe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed build of amddbgapi and rocgdb in prebuild_srock.sh
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist