[release/cvs-0.2.0] cvs/rccl: fix dmesg false positives and per-user RCCL hostfile#170
Merged
speriaswamy-amd merged 1 commit intoMay 18, 2026
Conversation
cijohnson
approved these changes
May 18, 2026
| # Note: 'Runlist is getting oversubscribed' and 'Expect reduced ROCm performance' | ||
| # are amdgpu kernel info-level messages (not errors). They fire routinely on | ||
| # large multi-rank RCCL runs whenever HSA queue count exceeds the runlist | ||
| # size, even when the run itself is healthy. Excluded from failure matching. |
Collaborator
There was a problem hiding this comment.
please add links to the reference doc in the comment for future reference
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #169 onto
release/cvs-0.2.0. Three small fixes from debugging a 28-noderccl_perfrun on a shared cluster:cvs/lib/verify_lib.py— surface amdgpu runlist oversubscription as a non-fatal WARN. Per AMD docs, this is a real perf-degrading state but the collective itself completes correctly. New module-levelwarn_patterns_dictscanned alongsideerr_patterns_dictinsideverify_dmesg_for_errors. Backward-compatible signature & return shape; existing callers untouched.cvs/tests/rccl/rccl_perf.py—verify_dmesg_for_errors(..., till_end_flag=False)so each parametrized test's dmesg scan is bounded by its own start/end window (prevents one test's kernel event from cascading into N reported failures).cvs/lib/rccl_lib.py— per-$USERmpirun hostfile path (/tmp/rccl_hosts_file_<USER>.txt); replaces thesudo rm -fworkaround that was on this branch.Conflict resolution notes
cvs/lib/rccl_lib.py: this branch had asudo rm -f /tmp/rccl_hosts_file.txtworkaround for the same multi-user collision. The per-user path supersedes it; workaround removed.cvs/tests/rccl/rccl_perf.py:maingatesverify_dmesg_for_errorsonif can_use_sudo:(passwordless-sudo guard not yet on this branch). For this cherry-pick the call stays unconditional — only thetill_end_flagvalue is changed — to avoid introducing an undefinedcan_use_sudoreference.cvs/lib/verify_lib.py: auto-merged cleanly.Test plan
main.python -c "import ast; ast.parse(...)"on all three files passes.rccl_perffrom this branch on the validation cluster.Refs: AIMVT-175