fix poor performance of slogdet when input dimension n=1 or 2#710
Open
cj401-amd wants to merge 2 commits intorocm-jaxlib-v0.8.2from
Open
fix poor performance of slogdet when input dimension n=1 or 2#710cj401-amd wants to merge 2 commits intorocm-jaxlib-v0.8.2from
cj401-amd wants to merge 2 commits intorocm-jaxlib-v0.8.2from
Conversation
cj401-amd
commented
Feb 10, 2026
cj401-amd
commented
- upstream PR: [ROCm] fix the performance issue when n=1 or 2 jax-ml/jax#34971
cj401-amd
added
enhancement
gulsumgudukbay
requested changes
Feb 10, 2026
gulsumgudukbay
left a comment
gulsumgudukbay
left a comment
There was a problem hiding this comment.
Please add a better title to the PR and also add detailed description, technical details and testing method and results to the description.
cj401-amd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.