Skip to content

Replace deprecated rocm-smi with amd-smi for NUMA topology #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KerwinTsaiii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace deprecated rocm-smi with amd-smi for NUMA topology #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/run_rochpl.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,11 @@ myq=$((rank/p))
cpulist=$(lscpu --parse=CPU,CORE,NODE | awk '!/#/' | tr ',' "\t" | sort -k 2 -g -s)

#construct list of devices and their numa affinities
devicelist=$(${rocm_dir}/bin/rocm-smi --csv --showtoponuma | tail -n +2 | tr ',' "\t")
# amd-smi replaces the deprecated rocm-smi. Its CSV emits one row per cpu_list
# entry per GPU, so collapse to the first row of each GPU and re-emit the legacy
# "cardN <numa_node> <numa_affinity>" layout the parsing below expects.
devicelist=$(${rocm_dir}/bin/amd-smi static --numa --csv | tail -n +2 | \
awk -F',' 'NF>1 && !seen[$1]++ {printf "card%s\t%s\t%s\n", $1, $2, $3}')

#count the cpus per core
threads_per_core=$(echo "${cpulist}" | grep -c ".* 0 .*")
Expand Down