fix(rocprim): benchmark_warp_sort updated to check if the wanted wavesize is supported - #4586
Closed
DeltaNeverUsed wants to merge 1 commit into
Closed
DeltaNeverUsed wants to merge 1 commit into
DeltaNeverUsed wants to merge 1 commit into
Conversation
…size is supported
amd-hsong
approved these changes
Feb 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4586 +/- ##
===========================================
- Coverage 65.49% 63.09% -2.40%
===========================================
Files 1608 1760 +152
Lines 256551 282276 +25725
Branches 36094 36696 +602
===========================================
+ Hits 168009 178075 +10066
- Misses 73354 88601 +15247
- Partials 15188 15600 +412
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
closing because of #4886 |
stanleytsang-amd
pushed a commit
that referenced
this pull request
Sep 18, 2026
…mpiler issues (#4586) (#4853) * Always bypass automatic atomic storage checks to prevent potential compiler issues * Waive atomic.local.pass.cpp if `_LIBCUDACXX_ATOMIC_UNSAFE_AUTOMATIC_STORAGE` is set. --------- (cherry picked from commit 549dd45947fac512a808ca8885f2e386b01d25d8) Co-authored-by: Yunsong Wang <yunsongw@nvidia.com> Co-authored-by: Wesley Maxey <71408887+wmaxey@users.noreply.github.com> (cherry picked from commit c2733c4a34dbe92524c731adaee5dc3fb9ec4b2f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds checks for whether the requested warp sizes are supported or not, instead of the benchmark crashing.
Technical Details
Test Plan
Test Result
Submission Checklist