[hipblaslt] tensilelite client validation threshold fix for tf32x3 and tf32x1#4890
Open
carsonbrownlee wants to merge 4 commits intodevelopfrom
Open
[hipblaslt] tensilelite client validation threshold fix for tf32x3 and tf32x1#4890carsonbrownlee wants to merge 4 commits intodevelopfrom
carsonbrownlee wants to merge 4 commits intodevelopfrom
Conversation
github-actions
bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
carsonbrownlee
changed the title
perfci run on commit 49fe485 |
perfci run on commit 4cad8a2 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4890 +/- ##
========================================
Coverage 65.35% 65.35%
========================================
Files 1718 1718
Lines 267217 267217
Branches 37047 37047
========================================
Hits 174637 174637
Misses 77072 77072
Partials 15508 15508
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
enable trig_init comparisons for tensilelite for tf32x3 and tf32x1.
Technical Details
Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1.
Test Plan
Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test.
Test Result
PASS