[rocWMMA] Add HIP RTC Regression tests#4891
Merged
Conversation
…4 is resolved Also don't set ROCM_PATH for MathCI, since we will use ROCWMMA_INCLUDE_PATH instead
evedovelli
approved these changes
Feb 26, 2026
Contributor
evedovelli
left a comment
evedovelli
left a comment
There was a problem hiding this comment.
The changes look good!
evedovelli
approved these changes
Feb 26, 2026
assistant-librarian bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Feb 27, 2026
[rocWMMA] Add HIP RTC Regression tests ## Motivation We currently have no testing available for any HIP RTC functionality with rocWMMA. ## Technical Details Add two batches of HIP RTC tests: 1) Perform basic non-rocwmma compiles with HIP RTC to ensure the basic flow works. 2) Perform HIP RTC compiles using the rocWMMA headers to prevent rocWMMA regressions. ROCM-864 tracks an issue that should be resolved in ROCm/rocm-systems#2605. Once that goes in we should come back and revert the `typedef`s that were added as a workaround to the source code we pass to HIP RTC when using rocwmma.h: ``` typedef signed char int8_t; typedef unsigned char uint8_t; typedef unsigned short uint16_t; typedef unsigned int uint32_t; ``` See ROCm/rocm-libraries#4928, which should be checked in once the fix is broadly available. ## Test Plan Manual testing. CI. ## Test Result Manual testing passes. Separate CI runs pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
kokolchin
pushed a commit
to kokolchin/rocm-libraries
that referenced
this pull request
Mar 4, 2026
## Motivation We currently have no testing available for any HIP RTC functionality with rocWMMA. ## Technical Details Add two batches of HIP RTC tests: 1) Perform basic non-rocwmma compiles with HIP RTC to ensure the basic flow works. 2) Perform HIP RTC compiles using the rocWMMA headers to prevent rocWMMA regressions. ROCM-864 tracks an issue that should be resolved in ROCm/rocm-systems#2605. Once that goes in we should come back and revert the `typedef`s that were added as a workaround to the source code we pass to HIP RTC when using rocwmma.h: ``` typedef signed char int8_t; typedef unsigned char uint8_t; typedef unsigned short uint16_t; typedef unsigned int uint32_t; ``` See ROCm#4928, which should be checked in once the fix is broadly available. ## Test Plan Manual testing. CI. ## Test Result Manual testing passes. Separate CI runs pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
NaveenElumalaiAMD
pushed a commit
that referenced
this pull request
Mar 6, 2026
## Motivation We currently have no testing available for any HIP RTC functionality with rocWMMA. ## Technical Details Add two batches of HIP RTC tests: 1) Perform basic non-rocwmma compiles with HIP RTC to ensure the basic flow works. 2) Perform HIP RTC compiles using the rocWMMA headers to prevent rocWMMA regressions. ROCM-864 tracks an issue that should be resolved in ROCm/rocm-systems#2605. Once that goes in we should come back and revert the `typedef`s that were added as a workaround to the source code we pass to HIP RTC when using rocwmma.h: ``` typedef signed char int8_t; typedef unsigned char uint8_t; typedef unsigned short uint16_t; typedef unsigned int uint32_t; ``` See #4928, which should be checked in once the fix is broadly available. ## Test Plan Manual testing. CI. ## Test Result Manual testing passes. Separate CI runs pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have no testing available for any HIP RTC functionality with rocWMMA.
Technical Details
Add two batches of HIP RTC tests:
ROCM-864 tracks an issue that should be resolved in ROCm/rocm-systems#2605. Once that goes in we should come back and revert the
typedefs that were added as a workaround to the source code we pass to HIP RTC when using rocwmma.h:See #4928, which should be checked in once the fix is broadly available.
Test Plan
Manual testing.
CI.
Test Result
Manual testing passes.
Separate CI runs pass.
Submission Checklist