[hipTensor] hipTensor buildable on Windows by evedovelli · Pull Request #4893 · ROCm/rocm-libraries

evedovelli · 2026-02-25T18:47:30Z

Motivation

Add support to building hipTensor on Windows

Technical Details

Set specific commands for Windows in CMake
Replace /dev/null with NUL for Windows
The hiptensor-export.h file is generated with macros to allow exporting the public API
printf format options were changed to fix warnings on Windows
Multiple platform specific functions were replaced to fix warnings on Windows
Calls to hiptensor_options were removed from samples (as they are not part of the public API)

Test Plan

hipTensor builds on both Linux and Windows.
No test is broken on Linux.
Tests and programs with mode HIPTENSOR_ALGO_ACTOR_CRITIC are expected to fail on Windows for now. They require updated kernel IDs, to be obtained next.

Test Result

Passing according to the test plan.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

cgmillette · 2026-03-06T18:40:24Z

projects/hiptensor/library/src/logger.cpp

+#include "include/logger.hpp"
+
+// Cross-platform safe file opening
+FILE* safeFopen(const char* filename, const char* mode)


This is not in hiptensor scope - intended?

cgmillette · 2026-03-06T18:51:28Z

projects/hiptensor/test/01_contraction/contraction_test.cpp

@@ -52,7 +52,11 @@ namespace hiptensor
        reset();

        // Handle our own outputs
+#ifdef _WIN32


To avoid this duplication in many files, maybe can have a helper function defined to silence the log file.

cgmillette · 2026-03-06T18:52:41Z

projects/hiptensor/test/common.hpp

+        std::mt19937                    gen(rd());
+        std::uniform_int_distribution<> dis(100000, 999999);
+
+        std::filesystem::path temp_dir      = std::filesystem::temp_directory_path();


Maybe on the off chance we should check if this file exists then re-roll?

cgmillette · 2026-03-06T18:55:14Z

projects/hiptensor/samples/CMakeLists.txt

@@ -76,7 +86,7 @@ else()

    cmake_minimum_required(VERSION 3.14)
    project(hiptensor_app)
-    add_compile_options(-std=c++17)
+    add_compile_options(-std=c++20)


Still compatible with CK ? CK is still using C++17

It's compatible. hipTensor had already moved to C++20 but the samples were being built with C++17. The ask came originally from CK which was planning to move to C++20.

cgmillette · 2026-03-06T19:02:33Z

projects/hiptensor/library/src/include/util.hpp

+        size_t                   required_size;
+        if(getenv_s(&required_size, buffer, sizeof(buffer), name) == 0 && required_size > 0)
+        {
+            return buffer;


Static buffer here being returned. Could change again before read.

Required size may need a check if it's bigger than the buffer.

cgmillette · 2026-03-06T19:14:06Z

projects/hiptensor/library/src/logger.cpp

+// Cross-platform safe file opening
+FILE* safeFopen(const char* filename, const char* mode)
+{
+#ifdef _WIN32


I might recommend to pull all the cross-platform utilities into a separate file to keep the macros isolated and unify the interface.

cgmillette · 2026-03-06T19:19:22Z

projects/hiptensor/test/llvm/CMakeLists.txt

@@ -25,11 +25,17 @@
 ###############################################################################

 # Find / configure LLVM
+if(WIN32)
+    # On Windows, LLVM is built with static dependencies and has a transitive dependency


Not sure, but does the INTERFACE obtained from llvm package take care of this already?

cgmillette

Looks good so far, just a few things to address

CongMa13 · 2026-03-07T23:17:57Z

projects/hiptensor/test/common.hpp

+        std::mt19937                    gen(rd());
+        std::uniform_int_distribution<> dis(100000, 999999);
+
+        std::filesystem::path temp_dir      = std::filesystem::temp_directory_path();


We did not use std::filesystem since it was not supported on some CI OSes.

But it has been a while. It will be great if all OSes support it now.

Ryker0627 · 2026-03-13T17:04:04Z

projects/hiptensor/library/src/include/util.hpp

@@ -49,6 +51,24 @@ namespace hiptensor
        return (numerator + divisor - 1) / divisor;
    }

+    // Cross-platform safe environment variable access
+    inline const char* getEnvironmentVariable(const char* name)


Suggest this function return a std::string so that you can use a std::string to replace the fixed size buffer "static thread_local char buffer[256];"

evedovelli added 3 commits February 20, 2026 10:02

[hipTensor] hipTensor buildable on Windows

48a84a1

Improve the export mechanism of public API and solve/supress warnings

44ea4b8

Use NUL instead of /dev/null on Windows

b5fcd68

evedovelli self-assigned this Feb 25, 2026

evedovelli requested a review from a team as a code owner February 25, 2026 18:47

evedovelli added the project: hiptensor label Feb 25, 2026

assistant-librarian bot added the organization: ROCm label Feb 25, 2026

evedovelli added 5 commits February 26, 2026 10:52

Only Windows requires find_package for ZLIB and ZSTD when building LLVM

da6f282

Always link tests against hiptensor_static and format CMakeLists

8117112

Small fixes

e2ca4f0

Use shared lib with exported internal symbols for tests

3a38bb9

Adjustments to tests' rpath

fd7e5b7

evedovelli requested a review from Ryker0627 March 5, 2026 14:04

Remove function to create static library and apply clang-format

44e0730

cgmillette reviewed Mar 6, 2026

View reviewed changes

cgmillette requested changes Mar 6, 2026

View reviewed changes

CongMa13 reviewed Mar 7, 2026

View reviewed changes

Ryker0627 reviewed Mar 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hipTensor] hipTensor buildable on Windows#4893

[hipTensor] hipTensor buildable on Windows#4893
evedovelli wants to merge 9 commits intodevelopfrom
users/evedovel/hiptensor-windows

evedovelli commented Feb 25, 2026 •

edited

Loading

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

evedovelli Mar 10, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette Mar 6, 2026

Uh oh!

cgmillette left a comment

Uh oh!

CongMa13 Mar 7, 2026

Uh oh!

Ryker0627 Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

evedovelli commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgmillette left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

evedovelli commented Feb 25, 2026 •

edited

Loading