[formocast][origami] Refine accuracy of math clocks#4907
Open
hcman2 wants to merge 4 commits intoROCm:developfrom
Open
[formocast][origami] Refine accuracy of math clocks#4907hcman2 wants to merge 4 commits intoROCm:developfrom
hcman2 wants to merge 4 commits intoROCm:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4907 +/- ##
========================================
Coverage 65.40% 65.40%
========================================
Files 1714 1714
Lines 266774 266774
Branches 37020 37020
========================================
Hits 174468 174468
Misses 76794 76794
Partials 15512 15512
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Simulate the FIFO behavior.
Test Plan
Run BBSTN 257 kernels with different MTs. Remove the global incremental code to make L2 always hit (so that very less memory latency included.) Compare the buffer_load issue cycles between formocast and rocprofv3.
Test Result
before patch
average difference per instruction: +12 cylces
after patch
average difference per instruction: +3 cylces
Refine origami test for local write and global read to approach the real cases.
Submission Checklist