Skip to content

Add some bsp drivers for F448, F472 and add bsp test codes.#9916

Merged
mysterywolf merged 1 commit intoRT-Thread:masterfrom
levizh:hc32_pr_20250114
Jan 20, 2025
Merged

Add some bsp drivers for F448, F472 and add bsp test codes.#9916
mysterywolf merged 1 commit intoRT-Thread:masterfrom
levizh:hc32_pr_20250114

Conversation

@JamieTx
Copy link
Contributor

@JamieTx JamieTx commented Jan 14, 2025

拉取/合并请求描述:(PR description)

[
Add some bsp drivers for F448, F472 and add bsp test codes.
]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • [✔ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • [✔ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • [✔ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • [✔ ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • [✔ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • [✔ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • [✔ ] 代码是高质量的 Code in this PR is of high quality
  • [✔ ] 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • [✔ ] 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the BSP label Jan 14, 2025
@BernardXiong BernardXiong added the -1 No vote label Jan 14, 2025
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交,但不再接受这么多的驱动库代码了,需要以软件包的方式

@mysterywolf
Copy link
Member

看起来 这个PR没有增加HAL库,只是修改以及搬移位置。

@JamieTx
Copy link
Contributor Author

JamieTx commented Jan 15, 2025

看起来 这个PR没有增加HAL库,只是修改以及搬移位置。

是的,只是更换了文件路径,并没有新增芯片库,新增的芯片将采用软件包的形式增加,现有是否可以保持?

@JamieTx JamieTx requested a review from BernardXiong January 15, 2025 03:20
@mysterywolf mysterywolf dismissed BernardXiong’s stale review January 20, 2025 03:12

这个PR没有增加HAL库,只是修改以及搬移位置。

@mysterywolf mysterywolf merged commit 77e9559 into RT-Thread:master Jan 20, 2025
45 checks passed
@JamieTx JamieTx deleted the hc32_pr_20250114 branch January 22, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-1 No vote BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants