fix: Environment problems#4
Open
Kamoris wants to merge 1 commit into
Open
Conversation
ppbbii
approved these changes
Jan 27, 2020
|
lgtm. Merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's more for discussion and refine than to merge. I was unable to use this cookiecutter as it assumed I have Git repo already created and my UID:GID is 1000:1000.
Also I think there are too much indirectness, eg.
make dotenvwhich basically just docp .env.example .env. Why to learn new command for this?According to UID:GID problem a solution might be to replace them by cookiecutter on project setup or just leave it to user, which in my opinion is also correct because this is exactly what envs are about - to allow user adjust project to his/her environment.