fix: Don't loop around when navigating#777
Merged
gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom Dec 10, 2025
Merged
fix: Don't loop around when navigating#777gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom
gonfunko merged 3 commits intoadd-screen-reader-support-experimentalfrom
Conversation
Contributor
|
FYI I noticed yesterday that there is still a call to create a |
Contributor
Author
|
Oh nice catch, went ahead and cleaned that up. |
maribethb
approved these changes
Dec 10, 2025
| workspace.getCursor().in(); | ||
| const newNode = workspace.getCursor().in(); | ||
| if (!newNode) { | ||
| workspace.getAudioManager().beep(260); |
Collaborator
There was a problem hiding this comment.
the magic number makes me twitch, but i think the ideal place for this to live is probably an errorBeep function or something in core, so it can stay for now ;p
Contributor
Author
There was a problem hiding this comment.
Yeah, agreed that would be nicer and should be dealt with when we finalize/merge back.
gonfunko
merged commit 24edccb
into
add-screen-reader-support-experimental
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes RaspberryPiFoundation/blockly#9496 by disabling looping when using the keyboard to navigate through the workspace, and playing an error tone when the end of the navigable tree is reached.