Skip to content

conformer search with solvation effect#737

Open
JintaoWu98 wants to merge 11 commits into
mainfrom
conf_gen
Open

conformer search with solvation effect#737
JintaoWu98 wants to merge 11 commits into
mainfrom
conf_gen

Conversation

@JintaoWu98

Copy link
Copy Markdown
Member

The new added level of theory and other features allow us to find conformers considering solvation effect.
It includes opening a subprocess to run multi_species opt job with solvent over the conformers from the RDkit conformers (without solvent), followed by designated post processes.

@codecov

codecov Bot commented Mar 4, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.92537% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.68%. Comparing base (be1f6c8) to head (efab850).
⚠️ Report is 722 commits behind head on main.

Files with missing lines Patch % Lines
arc/species/conformers.py 13.04% 39 Missing and 1 partial ⚠️
arc/main.py 6.66% 12 Missing and 2 partials ⚠️
arc/scheduler.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
- Coverage   73.82%   73.68%   -0.14%     
==========================================
  Files          99       99              
  Lines       27346    27406      +60     
  Branches     5717     5727      +10     
==========================================
+ Hits        20187    20195       +8     
- Misses       5733     5782      +49     
- Partials     1426     1429       +3     
Flag Coverage Δ
unittests 73.68% <14.92%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add log information for conformer with solvation spawned from the subprocess
This allows us to launch more opt jobs with smaller amount of conformers individually and parallelly, to speed up the process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant