Update icecc-create-env to upstream#28
Open
markbenvenuto wants to merge 1 commit intoRedBeard0531:masterfrom
Open
Update icecc-create-env to upstream#28markbenvenuto wants to merge 1 commit intoRedBeard0531:masterfrom
markbenvenuto wants to merge 1 commit intoRedBeard0531:masterfrom
Conversation
markbenvenuto
force-pushed
the
update_create_env
branch
from
12937b2 to
0ce0cd3
Compare
markbenvenuto
force-pushed
the
update_create_env
branch
from
0ce0cd3 to
f7ad282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the version with the upstream version and then added support for
--out.Tests
Fedora 31 builds
Probably get Gregory or Geert to test on Ubuntu.
Chroot Test Cases
Note: icecc-create-env complains about cc1plus but my real builds worked
src/mongo/db/modules/ninja/icecream/icecc-create-env /usr/bin/gcc /bin/true --out $(pwd)/build/icecc_envs/testg.tar.gz
src/mongo/db/modules/ninja/icecream/icecc-create-env /usr/bin/clang /bin/true --out $(pwd)/build/icecc_envs/testc.tar.gz
src/mongo/db/modules/ninja/icecream/icecc-create-env /opt/mongodbtoolchain/v3/bin/gcc /bin/true --out $(pwd)/build/icecc_envs/test3g.tar.gz
src/mongo/db/modules/ninja/icecream/icecc-create-env /opt/mongodbtoolchain/v3/bin/clang /bin/true --out $(pwd)/build/icecc_envs/test3c.tar.gz
src/mongo/db/modules/ninja/icecream/icecc-create-env /opt/mongodbtoolchain/v2/bin/gcc /bin/true --out $(pwd)/build/icecc_envs/test2g.tar.gz
src/mongo/db/modules/ninja/icecream/icecc-create-env /opt/mongodbtoolchain/v2/bin/clang /bin/true --out $(pwd)/build/icecc_envs/test2c.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/testg.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/testc.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/test3g.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/test3c.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/test2g.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/test2c.tar.gz
/usr/local/bin/icecc-test-env build/icecc_envs/test.tar.gz