Conversation
Pull Request Test Coverage Report for Build 23942034117Details
💛 - Coveralls |
|
|
||
| def refresh_module_links(blocks, url): | ||
| for block in blocks.values(): | ||
| if block.get("@type", "") != "slate": |
There was a problem hiding this comment.
there are a LOT of other blocks that have slate inside some fields
There was a problem hiding this comment.
Probably it could be better to iterate over tool keys and if is a Module, then force re-generate it
There was a problem hiding this comment.
Simpified it.
Now it iterates over the enhanced links tool keys and force refreshes only entries whose target is a Modulo
|
And add CHANGELOG please |
|
It will be great also if you could provide a test |
This comment was marked as resolved.
This comment was marked as resolved.
…nd remove unnecessary deepcopy
Added CHANGELOG and 2 test |
luca-bellenghi
left a comment
luca-bellenghi
left a comment
There was a problem hiding this comment.
In generale mi pare andar bene.
@cekk una verifica per te che conosci meglio il tool. Ma mi pare che ci siamo
| ------------------- | ||
|
|
||
| - Nothing changed yet. | ||
| - Fixed file type shown for links to Modulo files. |
There was a problem hiding this comment.
e che file type ci mette? Quello del file principale? L'entry nel changelog serve per capire cosa è cambiato, e più informazioni dai, meglio è. Poi la modifica in generale non è quella, ma che viene indicizzato il mime_type come quello del file principale..che poi venga usato in enhancedlinks è una cosa secondaria
5 participants
This PR updates Modulo MIME type data and refreshes enhanced link metadata during the upgrade, so links to Modulo files show the correct file type instead of stale values like TXT.