Add cancel dialog event listener & Export FeedbackService, FeedbackDirective#13
Open
workfel wants to merge 55 commits intoRickonChen:masterfrom
Open
Add cancel dialog event listener & Export FeedbackService, FeedbackDirective#13workfel wants to merge 55 commits intoRickonChen:masterfrom
workfel wants to merge 55 commits intoRickonChen:masterfrom
Conversation
workfel
commented
Nov 20, 2019
- I need service to force re-render the screenshot, because before set screen image i need to hide all private user information.
|
@workfel I think it would be great to make another service specifically for export. |
Author
|
ok, but why don't juste export the current Service ? |
|
I have nothing against it, but I would recommend at least renaming the current |
Author
|
Ok, i just updated the PR |
WIP: Fix/angular 8 & 9 compat - bump 2.0.0
chore: setup nvmrc
chore: add @digikare namespace on package
Looks like on es5 the string has a limit size of ~2Mb.. The image generated is cropped..
Fix/buffer size image & bump v2.0.1
Upgrade to v13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.