Closed
Conversation
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
cfcca7c to
f6218a8
Compare
Collaborator
|
@leeskelvin you will need to rebase this PR. It seems like a new release of EUPS is due, are you wanting this PR to be included? |
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
f6218a8 to
da8f1c6
Compare
Collaborator
Author
|
Rebased, thanks. I still need to perform a fairly significant rewrite based on @RobertLuptonTheGood's initial review which I haven't had time to get to yet, so please don't wait for me on this PR. I hope to have the updated PR in-place by the end of this week. |
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
2 times, most recently
from
c103228 to
61dfe37
Compare
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
61dfe37 to
4bc4212
Compare
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
4bc4212 to
9f1e33f
Compare
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
9f1e33f to
87a397f
Compare
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
bd482bf to
2ac8f02
Compare
leeskelvin
changed the title
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
2ac8f02 to
7d635cd
Compare
This commit adds a new argument to eups list: -C or --diff. This argument calculates the relative complement (aka, set difference) of declared version products with respect to currently setup products. All dependent products associated with the named product will be used as a reference, relative to the list of setup products managed by EUPS.
Following feedback from Nate Lust, the name "diff" may prove to be confusing to some, as it implies a diff between two versions and not necessarily a diff of all the product dependencies that come when setting up that product. It was felt that a name change to "overrides" (or, "-o" in short) would more accurately describe the operation here - i.e., it shows what products the end-user has locally set up which override those they would get when setting up lsst_distrib with a given version/tag. To further accentuate that difference, dependent products are now identified by virtue of a leading "|" symbol, as EUPS utilizes for the "--dependencies" argument.
leeskelvin
force-pushed
the
u/lskelvin/eups-diff
branch
from
7d635cd to
d99f2e4
Compare
Collaborator
Author
|
Withdrawing this PR due to lack of progress. I'll continue using a local alias to extract the information that would have been provided by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.