tickets/DM-52773: Improve index.json URL construction#160
Merged
Conversation
roceb
changed the title
index.json URL constructionindex.json URL construction
timj
approved these changes
Oct 6, 2025
Collaborator
timj
left a comment
timj
left a comment
There was a problem hiding this comment.
Please turn this into two commits since the two changes are completely distinct.
Also use posixpath.join for URLs.
roceb
force-pushed
the
tickets/DM-52773
branch
from
42fb238 to
81128cc
Compare
Collaborator
Author
|
Split the commit and updated the urls. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
index.jsonURL construction.Depending on how the pkgroot is passed, we might end up with a request to
{pkgroot}//index.jsoninstead of{pkgroot}/index. This change will correctly handling leading/trailing slashes in theurl.remove Nginx parsing workaround since we are no longer using nginx