Disable Numba looplift on _extract_pairs to suppress warning#24
Open
maxanier wants to merge 1 commit intoRohde-Schwarz:mainfrom
Open
Disable Numba looplift on _extract_pairs to suppress warning#24maxanier wants to merge 1 commit intoRohde-Schwarz:mainfrom
maxanier wants to merge 1 commit intoRohde-Schwarz:mainfrom
Conversation
Numby fails to looplift this function due to Unknown attribute 'extend' of type bytearray(uint8, 1d, C). To avoid printing a warning when running, just disable this right away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When numba is installed, every time I run a script that imports
RsWaveforma warning is printed to console:Maybe it is possible to somehow help Numba to looplift this function by giving it some information about the
extendmethod, but I don't know how.My proposed solution is to just specifically disabling looplifting on that function. It is not applied anyway due to above error and by disabling it no warning is printed.
Feel free to manually implement this without merging this PR or implementing a different solution