fix(core): remove outline and event from disabled segmented button#14026
Open
InnaAtanasova wants to merge 2 commits intomainfrom
Open
fix(core): remove outline and event from disabled segmented button#14026InnaAtanasova wants to merge 2 commits intomainfrom
InnaAtanasova wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
fix in fund-styles that brings this CSS there, too: SAP/fundamental-styles#6262 |
mikerodonnell89
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #14001
Description
Fixed incorrect behavior in segmented button reactive forms where disabled controls were responding to click events and triggering touch state changes.
TypeScript (segmented-button.component.ts)
@HostListener('click')to preventonTouched()from being called when component is disabled_toggleDisableButtons()that was re-registering event listeners when buttons were disabled (lines 393-398). This code was redundantly settingrole="option"(already set in_setButtonAttributes()) More critically, it was re-adding click/keyboard event listeners instead of removing them.CSS (segmented-button.component.scss)