update Vector functions to pass by reference #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling code on OpenMP backend we are seeing vector constuctors in the profiling data that are coming from pass by value. For vectors that are bigger than n=1 pass by reference should be more efficient.
Collaborator
Author
|
@Angelyr Do you know what settings ( |
Collaborator
Author
|
Looks like this might be #104 |
|
/runtests |
|
Test Result: failure (details) |
|
/runtests |
|
Test Result: failure (details) |
@jacobmerson The failing self-hosted tests are diffs against a 'gold' mesh that is stored in the repo; they also fail for master. I just pushed a commit that should fix that. Do you see a performance improvement with pass by reference? |
Collaborator
Author
|
I need to add some timing tests for this still. I will update this pull request when I get a chance to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling code on OpenMP backend we are seeing vector constuctors in the profiling data that are coming from pass by value. For vectors that are bigger than n=1 pass by reference should be more efficient.