refactor: dev tooling modernization (Ruff, Makefile, deprecations) @W-22187458#3972
Merged
refactor: dev tooling modernization (Ruff, Makefile, deprecations) @W-22187458#3972
Conversation
Reformat ~20 files (test fixtures, templates, markdown) to match the prettier v3 config already in .pre-commit-config.yaml (v3.1.0). No functional changes.
- Delete tox.ini (listed py38/39/310, referenced non-existent requirements_dev.txt, used tox 3 syntax -- dead code) - Remove /requirements/* from sdist includes (directory doesn't exist) - Update Makefile: dev-install uses uv sync, update-deps uses uv lock, lint uses ruff, release removes non-existent pin_dependencies.py, test-all documents CI-only multi-version testing, clean-test drops .tox - Add ruff to dev dependency group so make lint works before Ruff config migration
Replace three separate linting/formatting tools with Ruff: - black -> ruff format (same Black-compatible style) - flake8 -> ruff check (E/F/W/C90 aligned with what CI historically enforced) - isort -> ruff lint isort (same known-first-party settings) Delete standalone .flake8 config (rules moved to pyproject.toml). Update .pre-commit-config.yaml: replace ambv/black, flake8, isort hooks with astral-sh/ruff-pre-commit v0.15.8. Bump pre-commit-hooks to v5.0.0. Merge chore/prettier-v3-reformatting so Prettier and Ruff agree on formatted files. Small lint-driven fixes: isinstance for GitHub client checks; remove redundant EnvironmentVarGuard assignments; import Salesforce from simple_salesforce.api.
- click.MultiCommand -> click.Group in service.py and task.py (deprecated in Click 8.x, same API) - ssl.PROTOCOL_TLS -> ssl.PROTOCOL_TLS_SERVER in oauth/client.py (deprecated since Python 3.10, project requires 3.11+) - Table.exists()/drop()/create() -> inspector.has_table() with explicit bind in bulkdata/load.py (deprecated in SQLAlchemy 1.4)
- Align directory release notes generator expectations with Prettier markdown - Restore <!DOCTYPE html> in RobotLibDoc template (ElementTree.parse) - Add .prettierignore for template, VCR cassettes, diagram assets, Jinja templates - Normalize RobotLibDoc CSV sources and refresh page object line numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tox.ini; updateMakefiletargets foruv, Ruff, and release flow; drop stale/requirements/*sdist include..pre-commit-config.yaml; remove.flake8.click.MultiCommand→click.Group,ssl.PROTOCOL_TLS_SERVER, SQLAlchemyInspector.has_table+ explicit bind in bulk data load..prettierignoreand small test/template adjustments so Prettier/RobotLibDoc/ElementTree stay aligned.Note: This branch includes a merge commit from
chore/prettier-v3-reformattingso local hooks stay consistent. Prefer merging the Prettier PR first, then rebasing this branch ontomainif you want a linear history.Test plan
pre-commit run --all-filespytest cumulusci/